Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@angular-devkit/build-angular): move TS/NG configuration reading into compiler classes #25028

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 17, 2023

The TypeScript and Angular configuration reading (tsconfig.json) has now been moved into the Angular compilation classes (AOT/JIT) directly. This removes compilation specific functionality from the esbuild plugin and allows the plugin to focus primarily on integration with esbuild.

@clydin clydin added the target: rc This PR is targeted for the next release-candidate label Apr 17, 2023
…ding into compiler classes

The TypeScript and Angular configuration reading (`tsconfig.json`) has now been moved into the
Angular compilation classes (AOT/JIT) directly. This removes compilation specific functionality
from the esbuild plugin and allows the plugin to focus primarily on integration with esbuild.
@clydin clydin force-pushed the esbuild/ng-compiler-config branch from 7ffdf5d to 7b6e823 Compare April 17, 2023 15:09
@clydin clydin marked this pull request as ready for review April 17, 2023 15:23
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 17, 2023
@clydin clydin requested a review from alan-agius4 April 17, 2023 15:25
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 18, 2023
@angular-robot angular-robot bot merged commit d5fed32 into angular:main Apr 18, 2023
8 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants